-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlens stopped working in sub-repositories #3026
Comments
Can you provide more details as to when it stopped working? Was it on the upgrade to 14.5? Does 14.4 still work? Can you also provide more details as to your folder and repository setup? |
Hi, I just figured out how to revert Gitlens to 14.4, and it still works with this version. So it looks like 14.5 broke this feature. We simply have a top-level repository under which other repositories are checked out.
Gitlens used to handle this properly and would automatically run git commands in the correct repositories, but it looks like it's now running commands in the top repos even when targeting files in the sub repositories. |
Are |
Yes, they are. |
Same here, can confirm. Reverting to 14.4.1 fixed this. |
Unfortunately I can't reproduce this -- I tried setting up a root repo with .gitignore sub-repos and everything seems to work as expected. Can you provide more details about the specific setup? Network share? Folder on at the root of the drive? Also it could be helpful if you could provide logs from 14.4.1 (working?) and the latest pre-release (not working?) so I could compare what the difference is. Thanks! |
Sure! I'll try helping, however I most likely won't have time to do so over the weekend. In the mentioned issue I closed there are instructions to reliably reproduce the problem. About 10 colleagues of mine have experienced the same problem. Please check that issue, hopefully that would be enough info already. If not, I'll come back in a few days with logs 😉 |
This issue needs more information and has not had recent activity. Please provide the missing information or it will be closed in 7 days. Thanks! |
Sorry for a delay. Here are logs and videos of me reproducing the issue. Done in a container, with VS Code being installed inside of it. The steps I did:
Video 1, problematic 14.5.2 Peek.2023-12-04.10-24.mp4Video 2, working 14.4.1 Peek.2023-12-04.10-29.mp4Log from the first video:
Log from the working version:
|
@eamodio I hope that helps 👍 |
@xqrdot Can you expand the Commits view and see if each repository is reflected there? Also I've added more logging into tomorrow's ( |
@eamodio sure! Here's the video and the full log. The Commits view does update itself with the 3rd repository, while the Source Control preserves showing only 2. Peek.2023-12-05.12-19.mp4Expand to see logs of GitLens (pre-release) v2023.12.504
|
@xqrdot Thanks for the help getting to the bottom of this! Can you please verify this fix in tomorrow's ( You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view. |
@eamodio can confirm, the bug is fixed! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
In our environment, we have Git repositories checked out inside a top-level repository (but not defined as sub-modules).
Gitlens used to work well with them until a couple of days ago.
This is the error I'm seeing now:
[2023-11-21 09:04:52.304] [<path>/top_repos/sub_repos] Git Command failed: /bin/git -c core.quotepath=false -c color.ui=false blame --root --incremental -w -- <path>/top_repos/sub_repos/file.txt • no such path '<path>/top_repos/subrepos/file.txt' in HEAD [83ms]
I've tested on the pre-release as well, and it still fails.
Thanks,
Sébastien.
GitLens Version
v14.5.0
VS Code Version
1.83.0
Git Version
2.33.0
Logs, Screenshots, Screen Captures, etc
In the log, it looks like Gitlens is looking for the file in the top repository instead of going into the sub repositories like it used to:
The text was updated successfully, but these errors were encountered: