Search in Launchpad by PR URL. GitHub (#3543)

[sergeibbb]

Description

When I copy and paste a PR URL directly into the input box on the main step, it should search for that PR

Checklist

• I have followed the guidelines in the Contributing document
• My changes follow the coding style of this project
• My changes build without any errors or warnings
• My changes have been formatted and linted
• My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
• My changes have been rebased and squashed to the minimal number of relevant commits (typically 1 , don't squash my lovely commits, this PR is too big too be squashed).
• My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

[sergeibbb]

@sergiolms

After opening a URL in the browser, some items disappear but they still count, creating some empty items you cannot interact with:

It looks like existing behavior. Got to an item and put a query that doesn't match any command and these two item appear.

unclickable-items-in-launchpad.mp4

[axosoft-ramint]

I didn't manage to get through all the logic in launchpad.ts yet, so these comments are not yet complete, but cover all the other changes. Mostly just nitpicks and questions at this point - will test more thoroughly on Monday.

[axosoft-ramint]

Accidentally requested my own review on this PR. I removed it - feel free to re-request my review whenever it's ready to go.

[sergeibbb]

@axosoft-ramint

on the PR items that are search results, we should not have "pin" and "snooze" buttons/options, neither in this stage nor in the next stage after choosing the item (you will need to rebase this on main to see the "pin" and "snooze" options in the next step since that is new).

1. Do you mean the state of searching? Such as removing "pin" and "snooze" from every item.
2. Or only items that are "additional" so they don't belong to the current Launchpad set of PRs?

If # 1.

What if I want to pin an item but I don't see it in the launchpad, so I start searching it, then when it becomes clearly visible I click "pin". So, it becomes pinned.

Currently, clicking "pin" or "snooze" will do effectively nothing, as we cannot show categories until the search is empty, nor should those search results persist

Yes. We don't see the effect immediately, but the item has been affected, so in the non-searching state of the Launchpad we'll see the result of our action.

If # 2.
Probably the main problem is that we get "involves:@me" PRs from the GitHub. So, even if I've pinned a PR, so its ID is stored on GK.dev as "pinned", I won't see it in the Launchpad, because it's outside of the set of PRs where I'm involved.

However, it would make sense if we let users pin any PR.

But now I agree, it makes sense to remove these action from "additional" items that have been found.

Thoughts?
cc @eamodio @justinrobots

[axosoft-ramint]

@axosoft-ramint

on the PR items that are search results, we should not have "pin" and "snooze" buttons/options, neither in this stage nor in the next stage after choosing the item (you will need to rebase this on main to see the "pin" and "snooze" options in the next step since that is new).

1. Do you mean the state of searching? Such as removing "pin" and "snooze" from every item.
2. Or only items that are "additional" so they don't belong to the current Launchpad set of PRs?

If # 1.

What if I want to pin an item but I don't see it in the launchpad, so I start searching it, then when it becomes clearly visible I click "pin". So, it becomes pinned.

Currently, clicking "pin" or "snooze" will do effectively nothing, as we cannot show categories until the search is empty, nor should those search results persist

Yes. We don't see the effect immediately, but the item has been affected, so in the non-searching state of the Launchpad we'll see the result of our action.

If # 2.
Probably the main problem is that we get "involves:@me" PRs from the GitHub. So, even if I've pinned a PR, so its ID is stored on GK.dev as "pinned", I won't see it in the Launchpad, because it's outside of the set of PRs where I'm involved.

However, it would make sense if we let users pin any PR.

But now I agree, it makes sense to remove these action from "additional" items that have been found.

Thoughts?
cc @eamodio @justinrobots

Yes, I'm referring specifically to the "additional" items found in search from the app, and precisely because of the bug you describe. They should be considered temporary and we should not support pin or snooze on them for now because they won't stick around. If we do want to support that in the future, we can make a ticket for it.

[sergeibbb]

@axosoft-ramint

I suppose, what we do want to fix is to preserve search query on "back" step after selecting an item. Now the query gets lost every time I select an item and then go back.

[axosoft-ramint]

LGTM