Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for non https remotes #192

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

hjanuschka
Copy link
Contributor

@hjanuschka hjanuschka commented Nov 8, 2017

hey, thx for this awesome plugin ❤️

we have a gitlab instance running without https -> don't ask!

here is the required change to support the http protocol (and keep the default https; works for all remotes)

config sample:

{
    "gitlens.remotes": [{ "domain": "gitlab.xxxx.at", "type": "GitLab", "protocol": "http" }]
}

let me know if there is something to change/adapt.

@eamodio
Copy link
Member

eamodio commented Nov 8, 2017

@hjanuschka Thanks for the contribution, I will get this merged into GitLens 6 which is likely coming out tomorrow!

@eamodio eamodio self-assigned this Nov 8, 2017
@eamodio eamodio added this to the Soon™ milestone Nov 8, 2017
@eamodio eamodio changed the base branch from master to develop November 8, 2017 18:40
@eamodio eamodio merged commit dcfc662 into gitkraken:develop Nov 8, 2017
@eamodio eamodio removed this from the Soon™ milestone Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants