Uses VSCode as core.editor for rebase #2085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using git commands from terminal, one may prefer to use terminal editors to edit commit messages. But when using VSCode, it's better to use VSCode to edit commit messages. Currently gitlens uses VSCode to edit commit messages for amend. However it uses git's global
core.editor
for 'reword' in rebase. This PR ensures the usage of VSCode ascore.editor
for rebase.Closes #2084
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses