Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses VSCode as core.editor for rebase #2085

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

ShafinKhadem
Copy link
Contributor

Description

When using git commands from terminal, one may prefer to use terminal editors to edit commit messages. But when using VSCode, it's better to use VSCode to edit commit messages. Currently gitlens uses VSCode to edit commit messages for amend. However it uses git's global core.editor for 'reword' in rebase. This PR ensures the usage of VSCode as core.editor for rebase.

Closes #2084

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@eamodio eamodio self-assigned this Jul 15, 2022
@eamodio eamodio added this to the 12.2 milestone Jul 15, 2022
@eamodio eamodio merged commit af86a49 into gitkraken:main Jul 15, 2022
@eamodio
Copy link
Member

eamodio commented Jul 15, 2022

Thank you so much for your contribution!

Thank you!

@ShafinKhadem ShafinKhadem deleted the VSCode-core-rebase branch July 16, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use VSCode to edit commit message for 'reword' in rebase
2 participants