Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3687: Implement a Pro feature preview for the graph #3714

Closed

Conversation

sergiolms
Copy link
Contributor

@sergiolms sergiolms commented Nov 5, 2024

Description

Additionally, it includes changes from #3720 and #3694
Solves #3715

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergiolms sergiolms self-assigned this Nov 5, 2024
@sergiolms sergiolms marked this pull request as ready for review November 5, 2024 15:49
@sergiolms sergiolms force-pushed the feature/3687_implement_pro_feature_preview_for_the_graph branch 2 times, most recently from b01b703 to c3bd4d8 Compare November 5, 2024 15:58
@sergiolms sergiolms mentioned this pull request Nov 7, 2024
7 tasks
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS warnings when building:

image

Also, I'm seeing issues with the flow when testing it using the account simulator (debugging) in the Community state:

  1. The modal says "continuing gives you 7 days" when it should say 3 days
  2. Hitting the "continue" button links out to gkdev to register an account. If I recall correctly it should immediately start the preview, not require an account, right? Unless I'm interpreting the issue incorrectly.

graph preview issues

@sergiolms
Copy link
Contributor Author

sergiolms commented Nov 8, 2024

@axosoft-ramint

TS warnings when building:

image

I don't understand why I cannot see any of those warnings 😓
Captura de pantalla 2024-11-08 a las 10 42 04
Thanks for pointing those out. Fix is on the way.

Also, I'm seeing issues with the flow when testing it using the account simulator (debugging) in the Community state:

  1. The modal says "continuing gives you 7 days" when it should say 3 days
  2. Hitting the "continue" button links out to gkdev to register an account. If I recall correctly it should immediately start the preview, not require an account, right? Unless I'm interpreting the issue incorrectly.

I cannot reproduce that. This is how it looks like to me (with 0 days consumed)
Captura de pantalla 2024-11-08 a las 10 59 07

Did you run into this after consuming the three days of trial? The modal you encountered with that behavior should only display after you've consumed the three days.

@sergiolms sergiolms force-pushed the feature/3687_implement_pro_feature_preview_for_the_graph branch from 6f68c81 to 9d0dbbb Compare November 8, 2024 14:30
@eamodio eamodio added this to the 16.0 milestone Nov 11, 2024
@sergiolms sergiolms force-pushed the feature/3687_implement_pro_feature_preview_for_the_graph branch 2 times, most recently from b8e2b92 to 9c0071d Compare November 12, 2024 15:29
@sergiolms sergiolms force-pushed the feature/3687_implement_pro_feature_preview_for_the_graph branch from 9c0071d to 21ad073 Compare November 13, 2024 11:54
@eamodio
Copy link
Member

eamodio commented Nov 14, 2024

Closing in favor of 3d4b046

@eamodio eamodio closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants