Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_retried for (paging) jobs api #1045

Closed
s-rwe opened this issue Oct 19, 2023 · 0 comments · Fixed by #1046
Closed

Add include_retried for (paging) jobs api #1045

s-rwe opened this issue Oct 19, 2023 · 0 comments · Fixed by #1046

Comments

@s-rwe
Copy link
Contributor

s-rwe commented Oct 19, 2023

#954 added support for include_retried, in single-request JobApi calls to get the jobs for a pipeline.

This flag should also be supported in the paging calls the same way (i.e. the ones that return a Pager or Stream).

We ran into this limitation if pipelines have a large amount of jobs (> 100). In such cases, paging needs to be used to really get all jobs of a pipeline - and if retried ones are also desired, that's currently not possible to do.

I'm creating a PR to add this to JobApi accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant