Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add include_retried for jobs api #954

Closed
vmtrue opened this issue Apr 13, 2023 · 1 comment · Fixed by #955
Closed

Add include_retried for jobs api #954

vmtrue opened this issue Apr 13, 2023 · 1 comment · Fixed by #955

Comments

@vmtrue
Copy link
Contributor

vmtrue commented Apr 13, 2023

There is flag include_retried for getting jobs for pipeline.

https://docs.gitlab.com/ee/api/jobs.html#list-pipeline-jobs
@jmini
Copy link
Collaborator

jmini commented Apr 13, 2023

Thank you for this issue.

Feel free to create a PR to add it

vmtrue pushed a commit to vmtrue/gitlab4j-api that referenced this issue Apr 14, 2023
gitlab4j#954 add include_retried for jobs api
e41a6da
@jmini jmini mentioned this issue Apr 14, 2023
Merged
jabby pushed a commit that referenced this issue Jun 13, 2023
@vmtrue @jmini
#954 add include_retried for jobs api (#955)
7599f28 
* #954 add include_retried for jobs api

* Apply suggestions from code review

* Fix compile error

---------

Co-authored-by: vladimir.molodkin <vladimir.molodkin@aliexpress.ru>
Co-authored-by: Jérémie Bresson <dev@jmini.fr>
Co-authored-by: Jeremie Bresson <jeremie.bresson@unblu.com>
@s-rwe s-rwe mentioned this issue Oct 19, 2023
Closed
s-rwe added a commit to s-rwe/gitlab4j-api that referenced this issue Oct 19, 2023
@s-rwe
Support include_retried when getting jobs for a pipeline via paging
d89fdc6 
Follow-up to gitlab4j#954, which added the same for the non-paging request already.

If pipelines have a large amount of jobs (> 100 at least), need to use
the paging API to get all jobs (as GitLab limits paging size to max. 100).
JobApi didn't support the include_retried flag yet, in the methods that
support paging (i.e. those that return Pager<Job>/Stream<Job>)
@s-rwe s-rwe mentioned this issue Oct 19, 2023
Merged
jmini pushed a commit that referenced this issue Oct 31, 2023
@s-rwe
Support include_retried when getting jobs for a pipeline via paging (#…
7646876 
…1046)

Follow-up to #954, which added the same for the non-paging request already.

If pipelines have a large amount of jobs (> 100 at least), need to use
the paging API to get all jobs (as GitLab limits paging size to max. 100).
JobApi didn't support the include_retried flag yet, in the methods that
support paging (i.e. those that return Pager<Job>/Stream<Job>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#954 add include_retried for jobs api vmtrue/gitlab4j-api
2 participants
@vmtrue @jmini