Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#954 add include_retried for jobs api #955

Merged
merged 4 commits into from
Jun 13, 2023
Merged

#954 add include_retried for jobs api #955

merged 4 commits into from
Jun 13, 2023

Conversation

vmtrue
Copy link
Contributor

@vmtrue vmtrue commented Apr 14, 2023 •
edited by jmini
Loading

Fixes: #954

jmini
jmini requested changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do some minor changes (please review the suggestions carefully, I am not sure about them), but otherwise this looks good to me.

src/main/java/org/gitlab4j/api/JobApi.java Outdated Show resolved Hide resolved
src/main/java/org/gitlab4j/api/JobApi.java Outdated Show resolved Hide resolved
src/main/java/org/gitlab4j/api/JobApi.java Outdated Show resolved Hide resolved
src/main/java/org/gitlab4j/api/JobApi.java Outdated Show resolved Hide resolved
src/main/java/org/gitlab4j/api/JobApi.java Outdated Show resolved Hide resolved
src/main/java/org/gitlab4j/api/JobApi.java Outdated Show resolved Hide resolved
jmini
jmini approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied the requested changes and fixed the compile error.

I also merged the main branch into this PR.

@jabby jabby merged commit 7599f28 into gitlab4j:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabby jabby jabby approved these changes

@jmini jmini jmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add include_retried for jobs api
3 participants
@vmtrue @jmini @jabby