MergeRequest API add MergeRequestFilter withReviewer by ID OR by Username

[dstoianov]

Hi there,

It would be nice to have in API method to find all MRs where user is one of the reviewers.

We already have a similar API but in this case, it is

Examples of existing API

MergeRequestFilter filter = new MergeRequestFilter();
filter.withoutReviewerId(123L);
//OR
filter.withoutReviewerUsername("ABC");

Desired API

MergeRequestFilter filter = new MergeRequestFilter();
filter.withReviewerId(123L);
//OR
filter.withReviewerUsername("ABC");

if it is already implemented, please share this method or how it is possible to find all MRs assigned to user/currentUser

Thank you
Denys

[jmini]

Can you point to GitLab REST API documentation?

I didn't look into the details, but I think a pull-request can be created to add the missing methods.

[alexeybrod]

Can you point to GitLab REST API documentation?

https://docs.gitlab.com/ee/api/merge_requests.html

reviewer_id - Returns merge requests which have the user as a reviewer with the given user id. None returns merge requests with no reviewers. Any returns merge requests with any reviewer. Mutually exclusive with reviewer_username.
reviewer_username - Returns merge requests which have the user as a reviewer with the given username. None returns merge requests with no reviewers. Any returns merge requests with any reviewer. Mutually exclusive with reviewer_id.

Having filter.withoutReviewerId() but not filter.withReviewerId(), looks like it was accidentally missed in API implementation.

[jmini]

Indeed. Feel free to send a pull-request