RepositoryFileApi.updateFile PUT's to the wrong endpoint

[richardmward]

I think that org.gitlab4j.api.RepositoryFileApi.updateFile is sending it's PUT request to the wrong endpoint. I believe that:

put(Response.Status.OK, form.asMap(), "projects", projectId, "repository", "files", urlEncode(file.getFilePath()))

should be:

put(Response.Status.OK, form.asMap(), "projects", projectId, "repository", "files")

and that org.gitlab4j.api.RepositoryFileApi.file2form(RepositoryFile, String, String) should include:

addFormParam(form, "file_path", filepath, true);

[richardmward]

The same appears to be true of the org.gitlab4j.api.RepositoryFileApi.createFile method too.

[gmessner]

@richardmward
Per the GitLab API docs, both the update and create call should have the file path in URI. See the following links:
Create new file in repository
Update existing file in repository

Are these not working for you? If not, what is the version of the GitLab server you are going at?

[richardmward]

Ah, of course. I should have said, I am working against a V3 API at the moment, and was reading the V3 API docs - I should have thought to check to see if it had changed in V4, which it has.

Create V3
Update V3

[gmessner]

@richardmward
I can modify the methods to be version aware, will make that change in the next day or so.

[freeroy]

I catch this error too. my gitlab version is 8.3.2 and 7.11.4

please help~

[gmessner]

Support has been added for V3 for create, update, and delete repository file. The latest release (4.4.7) includes these updates.

[gmessner]

@freeroy
Just wanted to let you know that V3 support has been added. Unfortunately, I cannot test it since I do not have access to an older GitLab server, let me know if you run into any problems.