Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "internal" flag to NotesApi.createIssueNote() #1029

Merged
merged 1 commit into from
Sep 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/main/java/org/gitlab4j/api/NotesApi.java
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public Note getIssueNote(Object projectIdOrPath, Long issueIid, Long noteId) thr
* @throws GitLabApiException if any exception occurs
*/
public Note createIssueNote(Object projectIdOrPath, Long issueIid, String body) throws GitLabApiException {
return (createIssueNote(projectIdOrPath, issueIid, body, null));
return (createIssueNote(projectIdOrPath, issueIid, body, null, null));
}

/**
Expand All @@ -166,10 +166,26 @@ public Note createIssueNote(Object projectIdOrPath, Long issueIid, String body)
* @throws GitLabApiException if any exception occurs
*/
public Note createIssueNote(Object projectIdOrPath, Long issueIid, String body, Date createdAt) throws GitLabApiException {
return (createIssueNote(projectIdOrPath, issueIid, body, null, null)); }

/**
* Create a issues's note.
*
* @param projectIdOrPath the project in the form of an Long(ID), String(path), or Project instance
* @param issueIid the issue IID to create the notes for
* @param body the content of note
* @param createdAt the created time of note
* @param internal whether the note shall be marked 'internal'
* @return the created Note instance
* @throws GitLabApiException if any exception occurs
*/
public Note createIssueNote(Object projectIdOrPath, Long issueIid, String body, Date createdAt, Boolean internal) throws GitLabApiException {

GitLabApiForm formData = new GitLabApiForm()
.withParam("body", body, true)
.withParam("created_at", createdAt);
.withParam("created_at", createdAt)
.withParam("internal", internal);
;
Response response = post(Response.Status.CREATED, formData,
"projects", getProjectIdOrPath(projectIdOrPath), "issues", issueIid, "notes");
return (response.readEntity(Note.class));
Expand Down
11 changes: 10 additions & 1 deletion src/main/java/org/gitlab4j/api/models/Note.java
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public String toString() {
private Boolean resolvable;
private Participant resolvedBy;
private Date resolvedAt;
private Boolean internal;
private Type type;

private Position position;
Expand Down Expand Up @@ -270,7 +271,15 @@ public void setPosition(Position position) {
this.position = position;
}

@Override
public Boolean getInternal() {
return internal;
}

public void setInternal(Boolean internal) {
this.internal = internal;
}

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
Expand Down
1 change: 1 addition & 0 deletions src/test/resources/org/gitlab4j/api/note.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"resolvable": true,
"resolved": true,
"resolved_at": "2021-09-14T09:03:50.221Z",
"internal": false,
"system": false,
"noteable_id": 52,
"noteable_type": "Snippet",
Expand Down