New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of artifactPath to String #1031

Merged

jmini merged 1 commit into gitlab4j:6.x from jmini:patch-4

Nov 10, 2023

Collaborator

jmini commented Sep 25, 2023

The artifact_path is from type String:
https://docs.gitlab.com/ee/api/job_artifacts.html#download-a-single-artifact-file-by-job-id

Using a java.nio.file.Path to model this has very little benefit, since we have no real file system in that case.

The current work-around is to create a ArtifactsFile to set the filename attribute as String:

ArtifactsFile file = new ArtifactsFile();
file.setFilename(artifactPath); 
InputStream inputisStream = gitLabApi.getJobApi().downloadArtifactsFile(idOrPath(project), jobId, file);

IMO this breaking change on the 6.x branch is OK.


          Change type of artifactPath to String

f9c8be8

jmini merged commit 94a9a8f into gitlab4j:6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet