-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add erased_at attribute to Job class #1040
Conversation
I will rebase this branch on top of |
Thanks, should I in a future open PR to main branch? |
Yes please. |
This adds possibility to identify erased jobs.
What I did so far:
But I can't do
Probably I am not allowed to do an history rewrite on your branch. So I have pushed my commit to: branch pr_1040. |
de4de39
to
ebd0fb5
Compare
|
@luvarqpp: I have changed the target branch in PR #1040 Be aware that your local branch If you need to do one more change on this branch: |
Thanks. I had clean repo, so git pull have worked OK and accepted your forced push:
Rebase on main seems work like expected. Should I do any work? If yes, what? |
Nothing to do on your side. I have now merged the PR. Thank you for your contribution 🎉 |
This adds possibility to identify erased jobs. Some info and link also in javadoc.