Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get personal access token #1191

Merged
merged 5 commits into from
Nov 10, 2024
Merged

Add get personal access token #1191

merged 5 commits into from
Nov 10, 2024

Conversation

katrinSaleschus
Copy link
Contributor

adds getPersonalAccessToken method to PersonalAccessTokenApi

jmini
jmini requested changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Some small changes to the javadoc are needed (I made some suggestions)

In addition you need to run ./gradlew :spotlessApply to make sure the file is correctly formatted.

src/main/java/org/gitlab4j/api/PersonalAccessTokenApi.java Outdated Show resolved Hide resolved
src/main/java/org/gitlab4j/api/PersonalAccessTokenApi.java Outdated Show resolved Hide resolved
src/main/java/org/gitlab4j/api/PersonalAccessTokenApi.java Outdated Show resolved Hide resolved
src/main/java/org/gitlab4j/api/PersonalAccessTokenApi.java Outdated Show resolved Hide resolved
@katrinSaleschus
Copy link
Contributor Author

Thank you very much for your feedback! I hope now, everything is ready to merge.

@jmini jmini merged commit 5805b41 into gitlab4j:main Nov 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmini jmini jmini requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katrinSaleschus @jmini