Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing attributes for NotesApi and DiscussionApi (#1193) #1194

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

MadnessIRL
Copy link
Contributor

@MadnessIRL MadnessIRL commented Nov 18, 2024

Add attributes "created_at", "internal" for NotesApi commits and DiscussionApi merge requests

  • Replace unmappable characters in javadocs

Fixes: #1193

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The CI is complains because of some formatting that is not OK.

Run ./gradlew :spotlessApply to fix these violations.

…ussionApi merge requests (gitlab4j#1193)

- Replace unmappable characters in javadocs
@MadnessIRL
Copy link
Contributor Author

MadnessIRL commented Nov 21, 2024

@jmini done :) thank you for the feedback. Any further action required from my side?

@jmini
Copy link
Collaborator

jmini commented Nov 28, 2024

I am really late with all the PR reviews. I hope I will review and merge them this week. Sorry for the delay.

@jmini jmini merged commit 60259a6 into gitlab4j:main Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a new merge request note does not allow for optional parameters
2 participants