Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change types in Filter classes #1220

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Change types in Filter classes #1220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gitlab4j-models/src/main/java/org/gitlab4j/api/models/GroupFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
public class GroupFilter implements Serializable {
private static final long serialVersionUID = 1L;

private List<Integer> skipGroups;
private List<Long> skipGroups;
private Boolean allAvailable;
private String search;
private GroupOrderBy orderBy;
Expand All @@ -33,7 +33,7 @@ public class GroupFilter implements Serializable {
* @param skipGroups List of group IDs to not include in the search
* @return the reference to this GroupFilter instance
*/
public GroupFilter withSkipGroups(List<Integer> skipGroups) {
public GroupFilter withSkipGroups(List<Long> skipGroups) {
this.skipGroups = skipGroups;
return (this);
}
Expand Down
10 changes: 5 additions & 5 deletions gitlab4j-models/src/main/java/org/gitlab4j/api/models/IssueFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ public class IssueFilter implements Serializable {
private static final long serialVersionUID = 1L;

/**
* Return only the milestone having the given iid.
* Return only the issues having the given iid.
*/
private List<String> iids;
private List<Long> iids;

/**
* {@link org.gitlab4j.models.Constants.IssueState} Return all issues or just those that are opened or closed.
Expand Down Expand Up @@ -146,11 +146,11 @@ public String toString() {
}

/*- properties -*/
public List<String> getIids() {
public List<Long> getIids() {
return iids;
}

public void setIids(List<String> iids) {
public void setIids(List<Long> iids) {
this.iids = iids;
}

Expand Down Expand Up @@ -291,7 +291,7 @@ public void setNot(Map<IssueField, Object> not) {
}

/*- builder -*/
public IssueFilter withIids(List<String> iids) {
public IssueFilter withIids(List<Long> iids) {
this.iids = iids;
return (this);
}
Expand Down
Loading