Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of field SearchBlob.id to String #940

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

vadipp
Copy link
Contributor

@vadipp vadipp commented Apr 6, 2023

Fixes #936

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Long was not working, I consider that this breaking change of the type to String is OK for the id attribute.

@jmini jmini requested a review from jabby April 12, 2023 13:45
@jmini
Copy link
Collaborator

jmini commented Apr 12, 2023

@jabby do you have an opinion on this?

@jabby
Copy link
Collaborator

jabby commented Apr 12, 2023

Not really. I'm not sure if we should or not merge it in 5.x.

@vadipp
Copy link
Contributor Author

vadipp commented Apr 13, 2023

@jabby what doubts do you have exactly? I should emphasize that this is not a breaking change, but a fixing change :)

@gedeffe
Copy link

gedeffe commented Apr 19, 2023

Hello
@vadipp , Thanks for this fix, just when I need it ;-)
@jmini could it be possible to merge this fix into branch 6.x too ?

@jmini
Copy link
Collaborator

jmini commented Apr 19, 2023

In the branch 6.x this is not a problem. Right now during the -rc time we can do breaking changes.

IMO in the main branch, even if this is breaking from a java API perspective this should be allowed, since it is just not working the way it is now.
And if we merge it to main then we cascade it to 6.x as described in #926 (comment)

@jabby you seems to have some doubts that I respect, but can we have a decision here?

@jabby jabby merged commit 407166a into gitlab4j:main Apr 26, 2023
@vadipp vadipp deleted the fix-issue-936 branch April 28, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type of field SearchBlob.id - should be String
4 participants