Unique indexes are named different after the conversion

[jacobvosmaer]

On a fresh 7.10 PG GitLab installation, the index on users are:

Indexes:
    "users_pkey" PRIMARY KEY, btree (id)
    "index_users_on_authentication_token" UNIQUE, btree (authentication_token)
    "index_users_on_confirmation_token" UNIQUE, btree (confirmation_token)
    "index_users_on_email" UNIQUE, btree (email)
    "index_users_on_reset_password_token" UNIQUE, btree (reset_password_token)
    "index_users_on_admin" btree (admin)
    "index_users_on_created_at_and_id" btree (created_at, id)
    "index_users_on_current_sign_in_at" btree (current_sign_in_at)
    "index_users_on_name" btree (name)
    "index_users_on_username" btree (username)

On a 'converted' PG they are:

Indexes:
    "users_pkey" PRIMARY KEY, btree (id)
    "users_authentication_token_key" UNIQUE CONSTRAINT, btree (authentication_token)
    "users_confirmation_token_key" UNIQUE CONSTRAINT, btree (confirmation_token)
    "users_email_key" UNIQUE CONSTRAINT, btree (email)
    "users_reset_password_token_key" UNIQUE CONSTRAINT, btree (reset_password_token)
    "index_users_on_admin" btree (admin)
    "index_users_on_created_at_and_id" btree (created_at, id)
    "index_users_on_current_sign_in_at" btree (current_sign_in_at)
    "index_users_on_name" btree (name)
    "index_users_on_username" btree (username)

I don't know the difference between UNIQUE CONSTRAINT and UNIQUE. The index names are definitely different.

cc @DouweM

[DouweM]

Looks like add_index_statements.rb is setting the correct name, but it's skipping unique indexes that have already been added by db_converter.py which apparently doesn't respect those names. I'll have a look tomorrow.

UNIQUE and UNIQUE CONSTRAINT are a potato/potato thing.