Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer dereference importing gitlab_user #490

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

armsnyder
Copy link
Collaborator

Fixes #469

The issue was a missing nil check.

An importer test was ignoring the skip_confirmation field, probably masking the bug.

Note I replaced the importer with schema.ImportStatePassthrough because the importer was duplicated code from the read function, and the read function only uses the id attribute to read. The three extra attribute-sets (lines 31-33) are covered already by resourceGitlabUserSetToState.

@roidelapluie roidelapluie merged commit 6d084e6 into master Nov 23, 2020
@roidelapluie
Copy link
Collaborator

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

segmentation violation while running import for GitLab user (SIGSEGV)
2 participants