Fix nil pointer dereference importing gitlab_user #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469
The issue was a missing
nil
check.An importer test was ignoring the
skip_confirmation
field, probably masking the bug.Note I replaced the importer with
schema.ImportStatePassthrough
because the importer was duplicated code from the read function, and the read function only uses theid
attribute to read. The three extra attribute-sets (lines 31-33) are covered already byresourceGitlabUserSetToState
.