Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recreate project mirror on every run. #632

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

roidelapluie
Copy link
Collaborator

GitLab does not return username and password from the mirrors.
Therefore, let's ignore it in the provider.

Fix #504

Signed-off-by: Julien Pivotto roidelapluie@inuits.eu

Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One comment.

docs/resources/project_mirror.md Outdated Show resolved Hide resolved
@roidelapluie roidelapluie force-pushed the projectmirror branch 2 times, most recently from 3ef5ce2 to 94e87ea Compare July 23, 2021 12:34
@roidelapluie roidelapluie reopened this Aug 31, 2021
GitLab does not return username and password from the mirrors.
Therefore, let's ignore it in the provider.

This commit also adds pagination support.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
@nagyv nagyv merged commit d7059cf into gitlabhq:master Jan 21, 2022
@armsnyder armsnyder added this to the 3.9.0 milestone Jan 26, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This functionality has been released in 3.9.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

gitlab_project_mirror replaces existing mirror with each apply
3 participants