Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pehel page new registration and alumni form updates #457

Closed
rathorevaibhav opened this issue Jun 9, 2022 · 10 comments
Closed

Pehel page new registration and alumni form updates #457

rathorevaibhav opened this issue Jun 9, 2022 · 10 comments

Comments

@rathorevaibhav
Copy link
Member

Describe the task

  1. Update both forms with the following changes:
    1. Remove Area field from the forms
    2. Make institution field searchable
  2. When a new student is created, update the logic so that student->area = selectedInstitution->area
@rathorevaibhav
Copy link
Member Author

@Mariamraza15 @Kirtigour this is ready to test.

I could not re-create a test Pehel page. It's configurable from the admin dashboard that I don't have access to. I can, however, modify the forms that show up on the Pehel page.

Instead of updating the forms, I cloned them and created test forms. These are not being used on the Pehel page. There, the forms are intact.

Please use the following URLs instead of the Pehel page to test the student and alumni forms:

  1. Student form: https://medha.org.in/payments/new-register-test.php
  2. Alumni form: https://medha.org.in/payments/old-student-test.php

These forms are linked with the SIS staging application and submissions from these forms will show up on SIS staging.

NOTE: While testing, please ensure that the institution you are selecting has a Medha Area present in SIS dashboard.

@Kirtigour
Copy link
Collaborator

@rathorevaibhav, I tested this. It worked fine.
Just that, I could not see the Institution's name in the dropdown.

@rathorevaibhav
Copy link
Member Author

@Kirtigour can you share some more info? Which institution and which page you're talking about?

@Kirtigour
Copy link
Collaborator

@rathorevaibhav, Yes. So when I was filling out the form as a new student, while selecting the Institution I was not able to see the options in the dropdown. Attaching a screenshot for your reference -

image

@Mariamraza15
Copy link

Mariamraza15 commented Jun 14, 2022

@rathorevaibhav I tested for both new student and alumni, if we try to remove the Educational Institution, it doesn't get removed. The same institution appears again

@rathorevaibhav
Copy link
Member Author

hi @Mariamraza15 @Kirtigour
I've fixed the above feedback.

  1. Safari issue has been resolved
  2. The issue with the institution name when trying to remove is also resolved. There is one change here. When you have already selected a college and trying to search again in the field, the selected college name will no longer appear in the search field. It will be blank. I had added custom logic to put the name again in the search field but it was conflicting when you were trying to delete that.

I can continue to work on point 2 and make the selected college name come again without any issues. But it's going to take some more time. Let me know if we can launch like this.

@Mariamraza15
Copy link

hi @Mariamraza15 @Kirtigour I've fixed the above feedback.

  1. Safari issue has been resolved
  2. The issue with the institution name when trying to remove is also resolved. There is one change here. When you have already selected a college and trying to search again in the field, the selected college name will no longer appear in the search field. It will be blank. I had added custom logic to put the name again in the search field but it was conflicting when you were trying to delete that.

I can continue to work on point 2 and make the selected college name come again without any issues. But it's going to take some more time. Let me know if we can launch like this.

@rathorevaibhav Sure, you can launch it like this while working on the second issue.

@Kirtigour
Copy link
Collaborator

Kirtigour commented Jun 15, 2022

@rathorevaibhav, One thing we missed is that there are three programs which do not come under the Paid bracket.
Svapoorna, Swarambh and BMC are programs for which we need not require a payment option.

Also, can we make the field "Course Name" mandatory? Since it goes on the Certificate we do not want any gap there.

@rathorevaibhav
Copy link
Member Author

I found an issue while working on the course name mandatory in the alumni page.

I am able to submit the form and make payment when I have only filled the student id and our modules field. The other mandatory fields get ignored.

Screenshot:
image

In the screenshot, you will see in the background that the error shows up for required fields but it does not stop the payment popup to be displayed.

@rathorevaibhav
Copy link
Member Author

@Mariamraza15 the required fields updates are done.

I've created separate tracking for non-payable program/institution in #467

We can close this task once required fields are looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants