Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ethereum.org comment for 2025 #46

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

corwintines
Copy link

Updates the comment for ethereum.org gitpoap for 2025

Copy link

vercel bot commented Jan 23, 2025

@corwintines is attempting to deploy a commit to the GitPOAP Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitpoap-bot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 1:43pm

Copy link
Contributor

@colfax23 colfax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, just one comment on the copy. Let me know what you think. Excited to get this out!

src/utils.ts Outdated
@@ -43,7 +43,9 @@ const addHeadOverToGitPOAP = (comment: string): string =>

// Hardcode extra comments for ethereum-org-website
const ethereumOrgWebsiteComment =
'Be sure to join the [Ethereum.org discord](https://ethereum.org/discord) if you are interested in contributing further to the project or have any questions for the team.';
'Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional badges (OATs). Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not advertise other badge platforms through the GitPOAP bot - do you mind changing it just to "you may also unlock additional badges" or " ... additional rewards"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can change this for sure!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took this out now, let me know if theres anything else needed :)

src/utils.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants