-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ethereum.org comment for 2025 #46
base: main
Are you sure you want to change the base?
Conversation
@corwintines is attempting to deploy a commit to the GitPOAP Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, just one comment on the copy. Let me know what you think. Excited to get this out!
src/utils.ts
Outdated
@@ -43,7 +43,9 @@ const addHeadOverToGitPOAP = (comment: string): string => | |||
|
|||
// Hardcode extra comments for ethereum-org-website | |||
const ethereumOrgWebsiteComment = | |||
'Be sure to join the [Ethereum.org discord](https://ethereum.org/discord) if you are interested in contributing further to the project or have any questions for the team.'; | |||
'Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional badges (OATs). Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather not advertise other badge platforms through the GitPOAP bot - do you mind changing it just to "you may also unlock additional badges" or " ... additional rewards"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can change this for sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took this out now, let me know if theres anything else needed :)
Updates the comment for ethereum.org gitpoap for 2025