Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small dropdown style adjustements #96

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

filiptronicek
Copy link
Member

Description

Fixes some issues highlighted by @gtsiolis. This is only first batch focusing on GitHub so far.
image

Related Issue(s)

Fixes EXP-721

@filiptronicek filiptronicek requested a review from gtsiolis October 2, 2023 15:07
@filiptronicek filiptronicek self-assigned this Oct 2, 2023
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @filiptronicek. 🌮

Code changes look good.

Do you know how can I test this in Firefox?

@filiptronicek
Copy link
Member Author

@gtsiolis you can build it with

pnpm plasmo build --target=firefox-mv2 && pnpm plasmo package --target=firefox-mv2

and then in about:debugging#/runtime/this-firefox, install it. Note that settings will not work in this mode, because Firefox disables storage for temporary extensions.

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 2, 2023

Nice, UX LGTM. Thanks!

Added https://linear.app/gitpod/issue/EXP-753/ to keep track of more improvements in the README.

@gtsiolis gtsiolis merged commit 75d61c4 into main Oct 2, 2023
1 check passed
@gtsiolis gtsiolis deleted the ft/small-style-adjustements branch October 2, 2023 20:02
@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 2, 2023

@filiptronicek I merged this but have no clue what happens with the automatic release etc. It would be nice if we could document this in the README also as described in EXP-753. 🏓

@filiptronicek
Copy link
Member Author

filiptronicek commented Oct 2, 2023

Agree, @gtsiolis, the README deserves some more love, as there also is still a lot of outdated info. I'll look into it when I find the time, either this or next week.

And about the release: it does not happen on main pushes now. Only after a manual trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants