Add env var name/value length validation

Also, decrease maxlen for value from ~64k*3/4 to a nice round 32k.
gitpod-io · Feb 4, 2022 · 52916be · 52916be
1 parent a33a4a0
commit 52916be
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/components/dashboard/src/settings/EnvironmentVariables.tsx b/components/dashboard/src/settings/EnvironmentVariables.tsx
@@ -155,12 +155,18 @@ export default function EnvVars() {
         if (name.trim() === '') {
             return 'Name must not be empty.';
         }
+        if (name.length > 255) {
+            return 'Name too long. Maximum name length is 255 characters.';
+        }
         if (!/^[a-zA-Z0-9_]*$/.test(name)) {
             return 'Name must match /[a-zA-Z_]+[a-zA-Z0-9_]*/.';
         }
         if (variable.value.trim() === '') {
             return 'Value must not be empty.';
         }
+        if (variable.value.length > 32768) {
+            return 'Value too long. Maximum value length is 32768 characters.';
+        }
         if (pattern.trim() === '') {
             return 'Scope must not be empty.';
         }