[code browser]: Measure all sessions vs errored sessions

gitpod-io · Sep 8, 2022 · 5cbe872 · 5cbe872
1 parent 3743c60
commit 5cbe872
Show file tree

Hide file tree

Showing 12 changed files with 67 additions and 10 deletions.
diff --git a/components/supervisor/frontend/src/ide/ide-metrics-service-client.ts b/components/supervisor/frontend/src/ide/ide-metrics-service-client.ts
@@ -8,7 +8,8 @@ import { serverUrl } from '../shared/urls';
 
 export enum MetricsName {
     SupervisorFrontendClientTotal = "gitpod_supervisor_frontend_client_total",
-    SupervisorFrontendErrorTotal = "gitpod_supervisor_frontend_error_total"
+    SupervisorFrontendErrorTotal = "gitpod_supervisor_frontend_error_total",
+    SupervisorFrontendLoadTotal = "gitpod_vscode_web_load_total",
 }
 
 const MetricsUrl = serverUrl.asIDEMetrics().toString();

diff --git a/components/supervisor/frontend/src/index.ts b/components/supervisor/frontend/src/index.ts
@@ -30,6 +30,7 @@ window.addEventListener('error', (event) => {
             labels['error'] = 'LoadError';
         }
     }
+
     IDEMetricsServiceClient.addCounter(MetricsName.SupervisorFrontendErrorTotal, labels).catch(() => {});
 });
 //#endregion

diff --git a/install/installer/cmd/testdata/render/aws-setup/output.golden b/install/installer/cmd/testdata/render/aws-setup/output.golden
@@ -3165,6 +3165,11 @@ data:
               }
             ]
           },
+          {
+            "name": "gitpod_vscode_web_load_total",
+            "help": "Total count of supervisor frontend client loading / errored windows",
+            "labels": null
+          },
           {
             "name": "gitpod_supervisor_frontend_client_total",
             "help": "Total count of supervisor frontend client",
@@ -7426,7 +7431,7 @@ spec:
   template:
     metadata:
       annotations:
-        gitpod.io/checksum_config: eca723709a6407bcb546d40271986d74a615e9d48894864f7e344100a905dbcf
+        gitpod.io/checksum_config: b8a57f4a1f69581201c57d3c5c08057de4eb45898a15cb4be5ad41188c70efdb
       creationTimestamp: null
       labels:
         app: gitpod

diff --git a/install/installer/cmd/testdata/render/azure-setup/output.golden b/install/installer/cmd/testdata/render/azure-setup/output.golden
@@ -3083,6 +3083,11 @@ data:
               }
             ]
           },
+          {
+            "name": "gitpod_vscode_web_load_total",
+            "help": "Total count of supervisor frontend client loading / errored windows",
+            "labels": null
+          },
           {
             "name": "gitpod_supervisor_frontend_client_total",
             "help": "Total count of supervisor frontend client",
@@ -7260,7 +7265,7 @@ spec:
   template:
     metadata:
       annotations:
-        gitpod.io/checksum_config: eca723709a6407bcb546d40271986d74a615e9d48894864f7e344100a905dbcf
+        gitpod.io/checksum_config: b8a57f4a1f69581201c57d3c5c08057de4eb45898a15cb4be5ad41188c70efdb
       creationTimestamp: null
       labels:
         app: gitpod

diff --git a/install/installer/cmd/testdata/render/customization/output.golden b/install/installer/cmd/testdata/render/customization/output.golden
@@ -3865,6 +3865,11 @@ data:
               }
             ]
           },
+          {
+            "name": "gitpod_vscode_web_load_total",
+            "help": "Total count of supervisor frontend client loading / errored windows",
+            "labels": null
+          },
           {
             "name": "gitpod_supervisor_frontend_client_total",
             "help": "Total count of supervisor frontend client",
@@ -8653,7 +8658,7 @@ spec:
     metadata:
       annotations:
         gitpod.io: hello
-        gitpod.io/checksum_config: 7aca852c0c589f808186529f22f534f9db9fa4ae31546cedc307f7e26ec9c4cf
+        gitpod.io/checksum_config: 9f761f505089327879411de4e788ed30e4d8a4551d7ecbbd32d193cc8fd9af57
         hello: world
       creationTimestamp: null
       labels:

diff --git a/install/installer/cmd/testdata/render/external-registry/output.golden b/install/installer/cmd/testdata/render/external-registry/output.golden
@@ -3224,6 +3224,11 @@ data:
               }
             ]
           },
+          {
+            "name": "gitpod_vscode_web_load_total",
+            "help": "Total count of supervisor frontend client loading / errored windows",
+            "labels": null
+          },
           {
             "name": "gitpod_supervisor_frontend_client_total",
             "help": "Total count of supervisor frontend client",
@@ -7701,7 +7706,7 @@ spec:
   template:
     metadata:
       annotations:
-        gitpod.io/checksum_config: eca723709a6407bcb546d40271986d74a615e9d48894864f7e344100a905dbcf
+        gitpod.io/checksum_config: b8a57f4a1f69581201c57d3c5c08057de4eb45898a15cb4be5ad41188c70efdb
       creationTimestamp: null
       labels:
         app: gitpod

diff --git a/install/installer/cmd/testdata/render/gcp-setup/output.golden b/install/installer/cmd/testdata/render/gcp-setup/output.golden
@@ -3054,6 +3054,11 @@ data:
               }
             ]
           },
+          {
+            "name": "gitpod_vscode_web_load_total",
+            "help": "Total count of supervisor frontend client loading / errored windows",
+            "labels": null
+          },
           {
             "name": "gitpod_supervisor_frontend_client_total",
             "help": "Total count of supervisor frontend client",
@@ -7315,7 +7320,7 @@ spec:
   template:
     metadata:
       annotations:
-        gitpod.io/checksum_config: eca723709a6407bcb546d40271986d74a615e9d48894864f7e344100a905dbcf
+        gitpod.io/checksum_config: b8a57f4a1f69581201c57d3c5c08057de4eb45898a15cb4be5ad41188c70efdb
       creationTimestamp: null
       labels:
         app: gitpod

diff --git a/install/installer/cmd/testdata/render/minimal/output.golden b/install/installer/cmd/testdata/render/minimal/output.golden
@@ -3390,6 +3390,11 @@ data:
               }
             ]
           },
+          {
+            "name": "gitpod_vscode_web_load_total",
+            "help": "Total count of supervisor frontend client loading / errored windows",
+            "labels": null
+          },
           {
             "name": "gitpod_supervisor_frontend_client_total",
             "help": "Total count of supervisor frontend client",
@@ -7981,7 +7986,7 @@ spec:
   template:
     metadata:
       annotations:
-        gitpod.io/checksum_config: eca723709a6407bcb546d40271986d74a615e9d48894864f7e344100a905dbcf
+        gitpod.io/checksum_config: b8a57f4a1f69581201c57d3c5c08057de4eb45898a15cb4be5ad41188c70efdb
       creationTimestamp: null
       labels:
         app: gitpod

diff --git a/install/installer/cmd/testdata/render/statefulset-customization/output.golden b/install/installer/cmd/testdata/render/statefulset-customization/output.golden
@@ -3402,6 +3402,11 @@ data:
               }
             ]
           },
+          {
+            "name": "gitpod_vscode_web_load_total",
+            "help": "Total count of supervisor frontend client loading / errored windows",
+            "labels": null
+          },
           {
             "name": "gitpod_supervisor_frontend_client_total",
             "help": "Total count of supervisor frontend client",
@@ -7993,7 +7998,7 @@ spec:
   template:
     metadata:
       annotations:
-        gitpod.io/checksum_config: eca723709a6407bcb546d40271986d74a615e9d48894864f7e344100a905dbcf
+        gitpod.io/checksum_config: b8a57f4a1f69581201c57d3c5c08057de4eb45898a15cb4be5ad41188c70efdb
       creationTimestamp: null
       labels:
         app: gitpod

diff --git a/install/installer/cmd/testdata/render/use-pod-security-policies/output.golden b/install/installer/cmd/testdata/render/use-pod-security-policies/output.golden
@@ -3723,6 +3723,11 @@ data:
               }
             ]
           },
+          {
+            "name": "gitpod_vscode_web_load_total",
+            "help": "Total count of supervisor frontend client loading / errored windows",
+            "labels": null
+          },
           {
             "name": "gitpod_supervisor_frontend_client_total",
             "help": "Total count of supervisor frontend client",
@@ -8425,7 +8430,7 @@ spec:
   template:
     metadata:
       annotations:
-        gitpod.io/checksum_config: eca723709a6407bcb546d40271986d74a615e9d48894864f7e344100a905dbcf
+        gitpod.io/checksum_config: b8a57f4a1f69581201c57d3c5c08057de4eb45898a15cb4be5ad41188c70efdb
       creationTimestamp: null
       labels:
         app: gitpod

diff --git a/install/installer/cmd/testdata/render/workspace-requests-limits/output.golden b/install/installer/cmd/testdata/render/workspace-requests-limits/output.golden
@@ -3393,6 +3393,11 @@ data:
               }
             ]
           },
+          {
+            "name": "gitpod_vscode_web_load_total",
+            "help": "Total count of supervisor frontend client loading / errored windows",
+            "labels": null
+          },
           {
             "name": "gitpod_supervisor_frontend_client_total",
             "help": "Total count of supervisor frontend client",
@@ -7984,7 +7989,7 @@ spec:
   template:
     metadata:
       annotations:
-        gitpod.io/checksum_config: eca723709a6407bcb546d40271986d74a615e9d48894864f7e344100a905dbcf
+        gitpod.io/checksum_config: b8a57f4a1f69581201c57d3c5c08057de4eb45898a15cb4be5ad41188c70efdb
       creationTimestamp: null
       labels:
         app: gitpod

diff --git a/install/installer/pkg/components/ide-metrics/configmap.go b/install/installer/pkg/components/ide-metrics/configmap.go
@@ -46,6 +46,16 @@ func configmap(ctx *common.RenderContext) ([]runtime.Object, error) {
 				},
 			},
 		},
+		{
+			Name: "gitpod_vscode_web_load_total",
+			Help: "Total count of supervisor frontend client loading / errored windows",
+			Labels: []config.LabelAllowList{
+				{
+					Name:        "status",
+					AllowValues: []string{"loading", "failed"},
+				},
+			},
+		},
 		{
 			Name: "gitpod_supervisor_frontend_client_total",
 			Help: "Total count of supervisor frontend client",
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,6 +30,7 @@ window.addEventListener('error', (event) => { @@
                 labels['error'] = 'LoadError';
             }
         }
         IDEMetricsServiceClient.addCounter(MetricsName.SupervisorFrontendErrorTotal, labels).catch(() => {});
     });
     //#endregion
@@ Expand Down @@