Reduce env var value UI limit to 32k-1 for consistency

randomir · jankeromnes · randomir · commit 72ad89c44a84 · 2022-05-04T10:03:25.000-07:00
Co-authored-by: Jan Keromnes &lt;janx@linux.com&gt;
diff --git a/components/gitpod-protocol/src/protocol.ts b/components/gitpod-protocol/src/protocol.ts
@@ -251,8 +251,8 @@ export namespace UserEnvVar {
         if (variable.value.trim() === "") {
             return "Value must not be empty.";
         }
-        if (variable.value.length > 32768) {
-            return 'Value too long. Maximum value length is 32768 characters.';
+        if (variable.value.length > 32767) {
+            return 'Value too long. Maximum value length is 32767 characters.';
         }
         if (pattern.trim() === "") {
             return "Scope must not be empty.";

Original file line number	Diff line number	Diff line change
`@@ -251,8 +251,8 @@ export namespace UserEnvVar {`
`251`	`251`	`if (variable.value.trim() === "") {`
`252`	`252`	`return "Value must not be empty.";`
`253`	`253`	`}`
`254`		`- if (variable.value.length > 32768) {`
`255`		`- return 'Value too long. Maximum value length is 32768 characters.';`
	`254`	`+ if (variable.value.length > 32767) {`
	`255`	`+ return 'Value too long. Maximum value length is 32767 characters.';`
`256`	`256`	`}`
`257`	`257`	`if (pattern.trim() === "") {`
`258`	`258`	`return "Scope must not be empty.";`