Add env var name/value length validation

Also, decrease maxlen for value from ~64k*3/4 to a nice round 32k.
gitpod-io · May 4, 2022 · e41a76d · e41a76d
1 parent 403309e
commit e41a76d
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/components/gitpod-protocol/src/protocol.ts b/components/gitpod-protocol/src/protocol.ts
@@ -242,12 +242,18 @@ export namespace UserEnvVar {
         if (name.trim() === "") {
             return "Name must not be empty.";
         }
+        if (name.length > 255) {
+            return 'Name too long. Maximum name length is 255 characters.';
+        }
         if (!/^[a-zA-Z_]+[a-zA-Z0-9_]*$/.test(name)) {
             return "Name must match /^[a-zA-Z_]+[a-zA-Z0-9_]*$/.";
         }
         if (variable.value.trim() === "") {
             return "Value must not be empty.";
         }
+        if (variable.value.length > 32768) {
+            return 'Value too long. Maximum value length is 32768 characters.';
+        }
         if (pattern.trim() === "") {
             return "Scope must not be empty.";
         }