Handle compressed response in openvsx proxy

gitpod-io · Apr 4, 2022 · d979e61 · d979e61
1 parent 8ad398e
commit d979e61
Showing 1 changed file with 23 additions and 5 deletions.
diff --git a/components/openvsx-proxy/pkg/modifyresponse.go b/components/openvsx-proxy/pkg/modifyresponse.go
@@ -6,6 +6,7 @@ package pkg
 
 import (
 	"bytes"
+	"compress/gzip"
 	"fmt"
 	"io/ioutil"
 	"net/http"
@@ -48,19 +49,19 @@ func (o *OpenVSXProxy) ModifyResponse(r *http.Response) error {
 		return nil
 	}
 
-	body, err := ioutil.ReadAll(r.Body)
+	rawBody, err := ioutil.ReadAll(r.Body)
 	if err != nil {
-		log.WithFields(logFields).WithError(err).Error("error reading response body")
+		log.WithFields(logFields).WithError(err).Error("error reading response raw body")
 		return err
 	}
 	r.Body.Close()
-	r.Body = ioutil.NopCloser(bytes.NewBuffer(body))
+	r.Body = ioutil.NopCloser(bytes.NewBuffer(rawBody))
 
 	if r.StatusCode >= 500 || r.StatusCode == http.StatusTooManyRequests || r.StatusCode == http.StatusRequestTimeout {
 		// use cache if exists
 		bodyLogField := "(binary)"
-		if utf8.Valid(body) {
-			bodyStr := string(body)
+		if utf8.Valid(rawBody) {
+			bodyStr := string(rawBody)
 			truncatedSuffix := ""
 			if len(bodyStr) > 500 {
 				truncatedSuffix = "... [truncated]"
@@ -93,8 +94,25 @@ func (o *OpenVSXProxy) ModifyResponse(r *http.Response) error {
 	}
 
 	// no error (status code < 500)
+	body := rawBody
 	contentType := r.Header.Get("Content-Type")
 	if strings.HasPrefix(contentType, "application/json") {
+		if strings.EqualFold(r.Header.Get("Content-Encoding"), "gzip") {
+			gzipReader, err := gzip.NewReader(ioutil.NopCloser(bytes.NewBuffer(rawBody)))
+			if err != nil {
+				log.WithFields(logFields).WithError(err)
+			}
+
+			body, err = ioutil.ReadAll(gzipReader)
+			if err != nil {
+				log.WithFields(logFields).WithError(err).Error("error reading response body")
+				return err
+			}
+			gzipReader.Close()
+
+			r.Header.Del("Content-Encoding")
+		}
+
 		if log.Log.Level >= logrus.DebugLevel {
 			log.WithFields(logFields).Debugf("replacing %d occurence(s) of '%s' in response body ...", strings.Count(string(body), o.Config.URLUpstream), o.Config.URLUpstream)
 		}