[ws-proxy] Skip DNS errors when workspace is not available

gitpod-io · Jul 26, 2021 · f6aea00 · f6aea00
1 parent 79fd1d0
commit f6aea00
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/components/ws-proxy/pkg/proxy/pass.go b/components/ws-proxy/pkg/proxy/pass.go
@@ -5,6 +5,7 @@
 package proxy
 
 import (
+	"errors"
 	"fmt"
 	"net"
 	"net/http"
@@ -106,7 +107,12 @@ func proxyPass(config *RouteHandlerConfig, resolver targetResolver, opts ...prox
 				return
 			}
 
-			log.WithField("url", originalURL.String()).WithError(err).Error("proxied request failed")
+			var dnsError *net.DNSError
+			if !errors.As(err, &dnsError) {
+				// skip "no such host" errors (workspace service not available, yet)
+				log.WithField("url", originalURL.String()).WithError(err).Error("proxied request failed")
+			}
+
 			rw.WriteHeader(http.StatusBadGateway)
 		}