Skip to content

Hide unnecessary navigation elements on error page shown when users can not join a team #10503

Open
@gtsiolis

Description

@gtsiolis

Bug description

Following up from #10309, when users trying to join a team and the invite URL has expired, the team menu on the navigation shows an extra empty element.

This is probably because of all the logical checks like https://github.com/gitpod-io/gitpod/pull/10309/files#diff-64248da95f399a1cfe99b03aa662caf313faf9b7016999111605da5d61f1971dR269.

There are possibly other pages that users could end up in this case. Maybe worth making the menu logic more explicit. 💭

1️⃣ (Deleted Team) 2️⃣ (Reset Invite URL) 3️⃣ (User Blocked) 4️⃣ (???)
Screenshot 2022-06-07 at 5 19 32 PM (2) Screenshot 2022-06-07 at 5 16 44 PM (2) Screenshot 2022-06-07 at 5 16 05 PM (2) Screenshot 2022-06-07 at 5 20 03 PM (2)

Steps to reproduce

Try joining a team after 1️⃣ deleting the team, 2️⃣ resetting the invite URL, 3️⃣ blocking the user, 4️⃣ etc.

Notice the 1 extra blank breadcrumb item and the 2 redundant tab menu below the team scope selector, which could be safely removed, see screenshot below.

Frame 1097

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions