Skip to content

[installer] Move defaultBaseImageRegistryWhitelist out of experimental section #10791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
corneliusludmann opened this issue Jun 21, 2022 · 1 comment · Fixed by #11531
Closed

[installer] Move defaultBaseImageRegistryWhitelist out of experimental section #10791

corneliusludmann opened this issue Jun 21, 2022 · 1 comment · Fixed by #11531
Labels
team: delivery Issue belongs to the self-hosted team type: improvement Improves an existing feature or existing code

Comments

@corneliusludmann
Copy link
Contributor

corneliusludmann commented Jun 21, 2022 •
edited by lucasvaltl
Loading

We use defaultBaseImageRegistryWhitelist in production but it is part of the experimental section. We should move this out of experimental and replace all occurrences.

Proposal:

containerRegistry:
  # If you want to pull workspace base images from a private registry (with credentials), you need to make sure the credentials are available in containerRegistry.external.certificate and add this registry to privateBaseImageRegistries.
  privateBaseImageRegistries:
    - my-registry.example.com

I'm open to other naming proposals. However, I would like to avoid the term “whitelist”.

It is likely best to tackle this together with #11408

Value

  • Tech-debt
  • Allows the use of private base images
@corneliusludmann corneliusludmann added type: improvement Improves an existing feature or existing code team: delivery Issue belongs to the self-hosted team labels Jun 21, 2022
@corneliusludmann corneliusludmann mentioned this issue Jun 21, 2022
Closed
@lucasvaltl
Copy link
Contributor

Related to #1699

@lucasvaltl lucasvaltl mentioned this issue Jul 15, 2022
Closed
@nandajavarma nandajavarma mentioned this issue Jul 21, 2022
Merged
1 task
Repository owner moved this from 📓Scheduled to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team: delivery Issue belongs to the self-hosted team type: improvement Improves an existing feature or existing code
Projects
No open projects
🚚 Security, Infrastructure, and Delivery Team (SID)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[installer] move workspaceImage out of experimental config gitpod-io/gitpod
2 participants
@lucasvaltl @corneliusludmann