-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[installer] move workspaceImage out of experimental config #11531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-nvn-fix-11408.17 |
cf3db4d
to
a84c884
Compare
a84c884
to
9087227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine - just a question about deprecation vs removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Have you created a deprecation task and assigned to a future milestone? I'd suggest putting one in the December milestone similar to #11124. Also, link it to this PR so it's easily findable when we forget everything in future
Do you have an example gitpod.yml on how I can use my private image hosted on dockerhub. |
Description
This PR moves out options to specify the default workspace image and the
allowList
of private image registries out of theexperimental
section.The workspace image and the allow list for the registry can be specified as follows:
Related Issue(s)
Fixes #10791
Fixes #11408
How to test
core-dev
cluster.mkdir -p installer/licenses/nvn/
kubeconfig
content under theget-results
tab of the task on werft.config_patch.yaml
Release Notes
Documentation
Werft options: