Skip to content

Remove workspaceImage and defaultBaseImageRegistryWhitelist param from experimental config #11682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nandajavarma opened this issue Jul 27, 2022 · 0 comments
Labels
meta: never-stale This issue can never become stale team: delivery Issue belongs to the self-hosted team

Comments

@nandajavarma
Copy link
Contributor

Is your feature request related to a problem? Please describe

In #11531, the experimental.webapp.server.workspaceDefaults.workspaceImage and experimental.webapp.server.defaultBaseImageRegistryWhitelist parameters was deprecated. This should now be removed.

Describe the behaviour you'd like

Remove the deprecation notice from the config.go, the parameter from the experimental.go and where this is used in service.go

Describe alternatives you've considered

N/A

Additional context

The original suggestion was to remove this from the 2022.12.0 release. This may be moved as needs evolve

@nandajavarma nandajavarma added meta: never-stale This issue can never become stale team: delivery Issue belongs to the self-hosted team labels Jul 27, 2022
@nandajavarma nandajavarma added this to the release/2022.12 milestone Jul 27, 2022
Repository owner moved this from 🧊Backlog to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: never-stale This issue can never become stale team: delivery Issue belongs to the self-hosted team
Projects
No open projects
Development

No branches or pull requests

1 participant