Skip to content

[Usage-based] Adjust d_b_workspace_instance.attributedTeamId to be not team-specific #10822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #9036
jankeromnes opened this issue Jun 22, 2022 · 1 comment · Fixed by #10868
Closed
Tracked by #9036
Assignees
Labels
team: webapp Issue belongs to the WebApp team

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 22, 2022

Is your feature request related to a problem? Please describe

Adjust d_b_workspace_instance.attributedTeamId to be not Team-specific, so that it can also explicitly include attributed User IDs when relevant.

This way, the usage component can simply group by this "attribution ID" without needing to join with other tables.

Describe the behaviour you'd like

Describe alternatives you've considered

Additional context

Optionally, we can also back-fill attribution IDs in the production DB from when the column was first deployed (as an ad-hoc, one-time prod DB fix).

@jankeromnes jankeromnes added the team: webapp Issue belongs to the WebApp team label Jun 22, 2022
@jankeromnes jankeromnes self-assigned this Jun 22, 2022
@jankeromnes jankeromnes moved this to Scheduled in 🍎 WebApp Team Jun 22, 2022
@jankeromnes
Copy link
Contributor Author

Relevant sync summary from Slack (internal):

We discussed that:

  • Jan would drive the effort to fix this soon-ish
  • we decided to have one column name usageAttributionId
  • with prefixes (where the separator should be something not part of the ID, so not -)
  • the migration does not backfill data. We handle prod manually by either:
    • setting userIds from the point in time we started adding teamIds (safe), or
    • remove all values that do not start with team

@jankeromnes jankeromnes changed the title [Usage-based] Adjust d_b_workspace_instance.attributedTeamId to be not team-specific [Usage-based] Adjust 'd_b_workspace_instance.attributedTeamId' to be not team-specific Jun 22, 2022
@jankeromnes jankeromnes changed the title [Usage-based] Adjust 'd_b_workspace_instance.attributedTeamId' to be not team-specific [Usage-based] Adjust d_b_workspace_instance.attributedTeamId to be not team-specific Jun 22, 2022
@jankeromnes jankeromnes moved this from Scheduled to In Progress in 🍎 WebApp Team Jun 23, 2022
Repository owner moved this from In Progress to Done in 🍎 WebApp Team Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: webapp Issue belongs to the WebApp team
Projects
Archived in project
1 participant