Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer customization YAML does not recognise 'apiVersion: "v1"' #11106

Closed
mrsimonemms opened this issue Jul 4, 2022 · 1 comment · Fixed by #11268
Closed

Installer customization YAML does not recognise 'apiVersion: "v1"' #11106

mrsimonemms opened this issue Jul 4, 2022 · 1 comment · Fixed by #11268
Labels
team: delivery Issue belongs to the self-hosted team type: bug Something isn't working

Comments

@mrsimonemms
Copy link
Contributor

Bug description

The apiVersion: "v1" in a customization YAML gets rendered the Installer config correctly, but this is not picked up in the internals - it's omitted entirely when it's pushed through to the config map

apiVersion: "*" still works though

Steps to reproduce

When applying the customization file:

customization:
  - apiVersion: "v1"
    kind: "Service"
    metadata:
      name: "proxy"
      annotations:
        service.beta.kubernetes.io/aws-load-balancer-ip-address-type: ipv4

When looking at the config file (kubectl get configmaps -n gitpod gitpod -o jsonpath='{.data.config\.yaml}'), this is rendered as (note the missing apiVersion):

customization:
- kind: Service
  metadata:
    annotations:
      service.beta.kubernetes.io/aws-load-balancer-ip-address-type: ipv4
    creationTimestamp: null
    name: proxy
  spec:
    env: null

Workspace affected

No response

Expected behavior

The apiVersion should be implemented as v1

Example repository

No response

Anything else?

Internal discussion

@mrsimonemms mrsimonemms added type: bug Something isn't working team: delivery Issue belongs to the self-hosted team labels Jul 4, 2022
@mrsimonemms
Copy link
Contributor Author

I can't recreate this, but weirdly I could when I initially raised this ticket. I've tried it against the current version in main and also the June release without success.

I'll add this as a specific unit test, but I think that's the best I can do in this

cc @mrzarquon

mrsimonemms pushed a commit that referenced this issue Jul 11, 2022
This was raised as a specific issue in #11106, but cannot recreate this
issue. Test added to ensure that no regression happens.
roboquat pushed a commit that referenced this issue Jul 11, 2022
This was raised as a specific issue in #11106, but cannot recreate this
issue. Test added to ensure that no regression happens.
flaming-codes pushed a commit to flaming-codes/gitpod that referenced this issue Aug 1, 2022
This was raised as a specific issue in gitpod-io#11106, but cannot recreate this
issue. Test added to ensure that no regression happens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: delivery Issue belongs to the self-hosted team type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant