-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add pagination or infinite scroll support #11483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@laushinka, 20 is usually a good starting point for pagination that makes sense, but also depends on the context. However, I'd say let's go with 10, which is also a common approach, for brevity following our approach with other product areas like the workspaces list (see inactive workspaces grouping, etc) and given the upcoming collapsible component to be added on each entry and the potential addition of the usage graph above this list (see relevant discussion (internal)). We can always adjust this in future iterations. ➿ Looping in @jldec in case he has any strong preference towards a different solution. 🏀 |
Agree! I also thought 10 is a good start. For now we're doing the pagination in the client instead of the server, so once the data is loaded, going through the pages takes no time at all. |
I assume in the long-run we will switch to server-side pagination. Until then in case we notice any significant loading times, we could drop in a loading spinner while loading the data. ⏱️ |
Exactly. |
Problem to solve
Pagination. 📄
Proposal
Cc @laushinka @jldec because of our recent discussion related to pagination.
Designs
See design specs.
The text was updated successfully, but these errors were encountered: