Skip to content

[BitBucket] Failed calls to fetch .gitpod.yml are silently ignored #11649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svenefftinge opened this issue Jul 26, 2022 · 2 comments · Fixed by #11651
Closed

[BitBucket] Failed calls to fetch .gitpod.yml are silently ignored #11649

svenefftinge opened this issue Jul 26, 2022 · 2 comments · Fixed by #11651
Assignees
Labels
component: server type: bug Something isn't working

Comments

@svenefftinge
Copy link
Member

svenefftinge commented Jul 26, 2022

Bug description

https://github.com/gitpod-io/gitpod/blob/main/components/server/src/bitbucket/bitbucket-file-provider.ts#L65

silently ignores (debug) thrown errors and as a result the caller is interpreting it as no config and continues with the project config and eventually inferring one. This results in strange and surprising behavior. We should bail out if this happens.

I found this in the logs:

"HTTPError: Too Many Requests
    at /app/node_modules/bitbucket/lib/index.umd.js:15:6585
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)"

Steps to reproduce

try often enough

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@jmls
Copy link

jmls commented Jul 26, 2022

I would expect that the prebuild process should cancel with a warning message if it cannot access the file

Could we also please

  1. have a way of forcing a prebuild from the UI if one doesn't exist on a branch
  2. Be able to invalidate / delete an existing prebuild from the UI - this would then enable us to do "integrated chat" on status bar non functional #1 ;)

@svenefftinge
Copy link
Member Author

I would expect that the prebuild process should cancel with a warning message if it cannot access the file'

Yes, it should show as errored.

svenefftinge added a commit that referenced this issue Jul 26, 2022
fixes [BitBucket] Failed calls to fetch `.gitpod.yml` are silently ignored #11649
@svenefftinge svenefftinge self-assigned this Jul 26, 2022
@svenefftinge svenefftinge moved this to In Progress in 🍎 WebApp Team Jul 26, 2022
svenefftinge added a commit that referenced this issue Jul 26, 2022
fixes [BitBucket] Failed calls to fetch `.gitpod.yml` are silently ignored #11649
roboquat pushed a commit that referenced this issue Jul 27, 2022
fixes [BitBucket] Failed calls to fetch `.gitpod.yml` are silently ignored #11649
Repository owner moved this from In Progress to Done in 🍎 WebApp Team Jul 27, 2022
flaming-codes pushed a commit to flaming-codes/gitpod that referenced this issue Aug 1, 2022
fixes [BitBucket] Failed calls to fetch `.gitpod.yml` are silently ignored gitpod-io#11649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: server type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants