Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dropdown for the list of billing months #11685

Closed
Tracked by #9036
laushinka opened this issue Jul 27, 2022 · 4 comments
Closed
Tracked by #9036

Implement dropdown for the list of billing months #11685

laushinka opened this issue Jul 27, 2022 · 4 comments
Labels
component: dashboard feature: billing meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team

Comments

@laushinka
Copy link
Contributor

laushinka commented Jul 27, 2022

The dropdown was supposed to have been implemented in this ticket.

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 27, 2022

We could probably use the link dropdown we currently use in the /billing section, right?

<DropDown
activeEntry={
teamsWithBillingEnabled.find((t) => `team:${t.id}` === user?.usageAttributionId)?.name
}
customClasses="w-32"
renderAsLink={true}
entries={[
{
title: "(myself)",
onClick: () => setUsageAttributionTeam(undefined),
},
].concat(
teamsWithBillingEnabled.map((t) => ({
title: t.name,
onClick: () => setUsageAttributionTeam(t),
})),
)}
/>

Thanks for opening this follow-up issue, @laushinka! ✨

@gtsiolis
Copy link
Contributor

Cross-posting a relevant comment from #11526 (comment) containing designs specs for this issue.

Sidebar

See design specs for detailed padding, colors, font-size, and font-weight in case it helps, @laushinka!

@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 9, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale component: dashboard team: webapp Issue belongs to the WebApp team and removed meta: stale This issue/PR is stale and will be closed soon labels Nov 9, 2022
@gtsiolis
Copy link
Contributor

Closing this in favor of WEB-96.

Cross-posting the design proposal from there for visibility.

filters

@github-project-automation github-project-automation bot moved this to In Validation in 🍎 WebApp Team Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: billing meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

No branches or pull requests

2 participants