Skip to content

[local preview] Check arch and fail fast on non-supported arch #11792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #9075
corneliusludmann opened this issue Aug 2, 2022 · 4 comments · Fixed by #13123
Closed
Tracked by #9075

[local preview] Check arch and fail fast on non-supported arch #11792

corneliusludmann opened this issue Aug 2, 2022 · 4 comments · Fixed by #13123
Assignees
@Pothulapati
Labels
self-hosted: local-preview team: delivery Issue belongs to the self-hosted team type: improvement Improves an existing feature or existing code

Comments

@corneliusludmann
Copy link
Contributor

The local preview image does not work on Macs with Apple Silicon (e.g. M1). We should check the arch at the beginning of the container run and fail fast when the arch is not supported (with a clear error message).
@corneliusludmann corneliusludmann added type: improvement Improves an existing feature or existing code team: delivery Issue belongs to the self-hosted team labels Aug 2, 2022
@lucasvaltl lucasvaltl mentioned this issue Aug 5, 2022
Closed
10 tasks
@lucasvaltl lucasvaltl moved this from 🧊Backlog to 📓Scheduled in 🚚 Security, Infrastructure, and Delivery Team (SID) Aug 30, 2022
@lucasvaltl
Copy link
Contributor

Might be solved by #12468 (this is merged but might actually not work)

@lucasvaltl
Copy link
Contributor

Maybe the skateboard here is to always have a warning in the prerequisite check output in the CLI that warns that ARM / M1 macs are not supported. I.e. it is always there, wether you have a ARM based chip or not, those that don't have these chips can ignore this.

@Pothulapati Pothulapati mentioned this issue Sep 20, 2022
Merged
2 tasks
@Pothulapati Pothulapati moved this from 📓Scheduled to ⚒In Progress in 🚚 Security, Infrastructure, and Delivery Team (SID) Sep 20, 2022
Repository owner moved this from ⚒In Progress to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Sep 23, 2022
@Pothulapati
Copy link
Contributor

Merged #13123, which adds a confirmation from the user before proceeding but not sure if closing this is the right thing to do. Hence, Reopening it. Feel free to close it if you feel so.

@Pothulapati Pothulapati reopened this Sep 23, 2022
Repository owner moved this from ✨Done to 📓Scheduled in 🚚 Security, Infrastructure, and Delivery Team (SID) Sep 23, 2022
@lucasvaltl
Copy link
Contributor

Will close this for now - we have a skateboard fix, let's measure the impact of that and then iterate.

Repository owner moved this from 📓Scheduled to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pothulapati Pothulapati

Labels
self-hosted: local-preview team: delivery Issue belongs to the self-hosted team type: improvement Improves an existing feature or existing code
Projects
No open projects
🚚 Security, Infrastructure, and Delivery Team (SID)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[local-preview] Warn and Confirm from user before proceeding gitpod-io/gitpod
3 participants
@Pothulapati @lucasvaltl @corneliusludmann