Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workspaces page #12033

Closed
gtsiolis opened this issue Aug 10, 2022 · 4 comments
Closed

Improve workspaces page #12033

gtsiolis opened this issue Aug 10, 2022 · 4 comments
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 10, 2022

Problem to solve

Following up with all the recent features added to the product like Teams & Projects and the upcoming Usage-Based Pricing (UBP), the Workspaces page could benefit from new patterns, components, or layouts.

This could tackle potential improvements like #3594, #5125, #10140, #4635, #4225 and more.

Proposal

TBD (To be discussed)

@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Aug 10, 2022
@gtsiolis gtsiolis changed the title Improve workspaces lists Improve workspaces page Aug 10, 2022
@gtsiolis
Copy link
Contributor Author

Posting an early design from a relevant discussion (internal).

BEFORE AFTER
workspaces-page-before workspaces-page-after

@jldec
Copy link
Contributor

jldec commented Oct 27, 2022

Thanks @gtsiolis - I copied some feedback below captured during our discussion earlier. I would recommend editing the list below to indicate which item is about which column (or perhaps connect the list to the screenshot)

Some design thinking points:

  1. Removes one column, from four to three.
    jl - nice - reduces duplication, more responseive. (would like a prototype to test responsivenesss - e.g. when cells are narrower and wrap)

  2. Adds back the table header.
    jl - nice - explains the columns more clearly

  3. Keeps the workspace ID as the primary table identifier.
    jl - agree

  4. Introduces workspace class.
    jl - agree - should surface this info everywhere we can (ws class-names messy)

  5. Uses label for running status indicator for better accessibility.
    jl - agree (states should already be there ?)

  6. Combines context URL with branch.
    jl - ok - It’s helpful to surface different flavors of context url but not at the expense of seeing the repo info and being able to go to the repo. Based on the header, the column is supposed to be mainly about the repo.

  7. Removes the repository URL in favor of the new combined context.
    jl - I don’t like losing the repo URL entirely - is it clickable to go to github? I would put this in bold at the top of the cell, not below the team/project.

  8. Introduces project association.
    jl - nice idea - but what if the project is not visible? not sure if it’s easy to do -

  9. Introduces team association.
    jl - nice idea - but how to handle if the team is not visible?

  10. Nudges users to add repository as project when not added.
    jl - how would this work with teams? need to clarify the flow before committing to this.

  11. Surfaces credits used per workspace.
    jl - this differs from the usage per workspace session - i think it will confuse users unless we make it clear that this is an aggregate when there have been multiple sessions/instances for one workspace e.g. by showing the breakdown or session count.

  12. Changes orientation of the more actions dropdown button.
    jl - fine with this 🙂

@stale
Copy link

stale bot commented Feb 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Feb 5, 2023
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Feb 5, 2023
@gtsiolis
Copy link
Contributor Author

gtsiolis commented May 2, 2023

Closing in favor of UX-26.

@gtsiolis gtsiolis closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

2 participants