-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Rename "New" files back - add Tooltip to ws branch #16397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-bmh-workspace-entry-tweaks.1 because the annotations in the pull request description changed |
/werft run with-preview with-dedicated-emulation with-clean-slate-deployment recreate-vm 👍 started the job as gitpod-build-bmh-workspace-entry-tweaks.2 |
/werft run with-preview with-clean-slate-deployment recreate-vm 👍 started the job as gitpod-build-bmh-workspace-entry-tweaks.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold would be good to squash the commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -74,7 +74,9 @@ export const WorkspaceEntry: FunctionComponent<Props> = ({ info }) => { | |||
</a> | |||
</ItemField> | |||
<ItemField className="w-2/12 flex flex-col my-auto"> | |||
<div className="text-gray-500 dark:text-gray-400 overflow-ellipsis truncate">{currentBranch}</div> | |||
<div className="text-gray-500 dark:text-gray-400 overflow-ellipsis truncate"> | |||
<Tooltip content={currentBranch}>{currentBranch}</Tooltip> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some raw thoughts on this change:
- It's better to avoid as many tooltips as possible, mostly for accessibility.
- Tooltip seems redundant when the branch is not truncated.
- Tooltip seems redundant when the default branch is by convention short like
master
ormain
. - This could use the
title
attribute as a fallback instead. - The tooltip will become less needed with changes in Improve workspaces page #12033, see also screenshot below.
- Following up from the changes in Improve workspaces page #12033 the branch could be truncated in some edge cases but still be accompanied by a copy-to-clipboard button next to the branch name.
Early design for improving the workspaces list |
---|
![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah the new design will help so we wouldn't need something like this. My motivation is that I end up with the following situation:
and the only way I can tell what's what is by closing any sidebars, and hoping it doesn't clip (and still does sometimes). This seemed like a reasonable / easy way to offer a recourse for a user to see their branch.
I'm not sure I follow what accessibility concerns there would be with this. Using our custom tooltip component is essentially the same behavior as using title, but a slightly better ux.
I do agree it is redundant, and shouldn't be needed (and won't in new designs whenever we can do them). At the moment, I was hoping to improve it slightly until we do have time to work on the new designs. It's easy enough to remove, so I will if you still think we should, but also feels like a quality of life improvement that I know I'd benefit from, so I assume some others will to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@selfcontained I'm coming to this a bit late to share some thoughts on this topic—I also understand where you are coming from and I'm looking forward to improving the bits in this page.
I'm not sure I follow what accessibility concerns there would be with this. Using our custom tooltip component is essentially the same behavior as using title, but a slightly better ux.
To clarify, I believe there are cases where tooltips can be a helpful and valuable component for surfacing information like describing a button action, provide a hint, etc. However, it's easy to skip making it accessible, as tooltips that only appear on mouse over are inaccessible for users that rely on keyboards to navigate. This is a perfect example as the branch element is not accessible by keyboard and the tooltip never shows up.
I do agree it is redundant, and shouldn't be needed (and won't in new designs whenever we can do them).
💯
... I was hoping to improve it slightly until we do have time to work on the new designs. It's easy enough to remove, so I will if you still think we should, but also feels like a quality of life improvement that I know I'd benefit from, so I assume some others will to.
Sounds like a good MVC we can easily update or revert when we start working on the new page designs. Also, since the changes in #15716 this seems like ok to leave it there for now. 🤝
Also, regarding the comment below in #16397 (comment):
I noticed something with tooltip change I mad here makes it hard to hover over the tip and select/copy the value now.
Since a tooltip disappears when a user hovers away, we should not include information that is pertinent for the user to complete a task. We should instead rely on other patterns or components for making vital information always visible and accessible, like help text, labels, etc.
49edee7
to
9739006
Compare
I noticed something with tooltip change I mad here makes it hard to hover over the tip and select/copy the value now. I'll figure that out before merging this. |
/unhold |
Description
New
from them after refactoring the Workspaces list components.How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh