Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better surface Stripe sign-up errors in the UI #12580

Closed
jankeromnes opened this issue Sep 1, 2022 · 0 comments · Fixed by #12872
Closed

Better surface Stripe sign-up errors in the UI #12580

jankeromnes opened this issue Sep 1, 2022 · 0 comments · Fixed by #12872
Assignees
Labels
team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 1, 2022

Bug description

Follow-up to #12343 / #12376

When testing the PR, we noticed two separate UX problems:

  1. When you sign up with a given currency, then cancel, then try to sign up with a different currency, Stripe fails with this error:
Error: You cannot combine currencies on a single customer. This customer has had a subscription, coupon, or invoice item with currency eur

It would be cool to handle this problem specifically, e.g. by preventing existing customers from selecting a different currency, and/or by suggesting that they reach out to Gitpod's support (so that we can de-activate the Stripe customer account, allowing the user to create a new one in a different currency).

  1. In general, when an error happens on Stripe sign-up, it is not properly shown in the UI, and is currently only visible in the browser console & in the server logs. It would be nice to show visually in the UI that something went wrong and what can be done about it.

Steps to reproduce

  1. Sign up a team up to usage-based in one currency
  2. Cancel
  3. Try to sign up the same team again but in a different currency (it fails, but shows no error in the UI)

Workspace affected

No response

Expected behavior

It should not be possible to try and sign in again with a different currency. Instead, we could prevent the selection of a different currency, and/or suggest that customers reach out to support if they want to switch to a different currency.

Example repository

No response

Anything else?

No response

@jankeromnes jankeromnes added type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Sep 1, 2022
@geropl geropl moved this to Next Milestone in 🍎 WebApp Team Sep 6, 2022
@geropl geropl moved this from Next Milestone to Scheduled in 🍎 WebApp Team Sep 9, 2022
@geropl geropl removed the status in 🍎 WebApp Team Sep 12, 2022
@jankeromnes jankeromnes self-assigned this Sep 12, 2022
@geropl geropl moved this to Scheduled in 🍎 WebApp Team Sep 12, 2022
@jankeromnes jankeromnes moved this from Scheduled to In Progress in 🍎 WebApp Team Sep 12, 2022
Repository owner moved this from In Progress to Done in 🍎 WebApp Team Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant