Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Show error messages in the UI when upgrading with Stripe fails #12872

Merged
merged 1 commit into from
Sep 13, 2022
Merged

[dashboard] Show error messages in the UI when upgrading with Stripe fails #12872

merged 1 commit into from
Sep 13, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Sep 12, 2022 •
edited
Loading

Description

Show error messages in the UI when upgrading with Stripe fails for any reason.

Related Issue(s)

Fixes #12580

How to test

  1. Create a team called "Gitpod [Something]"
  2. Try to upgrade using an invalid credit card number, or one of Stripe's failing test cards -- this should always show an error message
  3. Upgrade using a regular test card in the currency USD (e.g. 4242 4242 4242 4242, 4/24, 424) -- this should work
  4. Once it went through, manage and cancel your Stripe subscription
  5. Upgrade again with a regular test card, but this time with the currency EUR
  6. The payment method should go through, but on the next page you should see an error message

(Note: Currently that second step error message is redacted, and will just say that "upgrading failed" while the actual error message is hidden in server logs -- we can improve this UX in a follow-up step.)

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Sep 12, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jx-show-stripe-error.1
(with .werft/ from main)

@jankeromnes jankeromnes changed the title [dashboard] Show an error message when upgrading with Stripe fails [dashboard] Show error messages in the UI when upgrading with Stripe fails Sep 12, 2022
@roboquat roboquat added size/S and removed size/XS labels Sep 12, 2022
@jankeromnes jankeromnes marked this pull request as ready for review September 12, 2022 15:32
@jankeromnes jankeromnes requested a review from a team September 12, 2022 15:32
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 12, 2022
andrew-farries
andrew-farries approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for question about the error messages.

components/dashboard/src/components/UsageBasedBillingConfig.tsx Outdated Show resolved Hide resolved
components/dashboard/src/teams/TeamUsageBasedBilling.tsx Outdated Show resolved Hide resolved
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Sep 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Many thanks for the reviews! 🙏

Nits addressed, confirmed still working as intended. Releasing the breaks.

/unhold

@roboquat roboquat merged commit c92b555 into main Sep 13, 2022
@roboquat roboquat deleted the jx/show-stripe-error branch September 13, 2022 07:29
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better surface Stripe sign-up errors in the UI
3 participants
@jankeromnes @andrew-farries @roboquat