Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook events are not registered properly for GitHub PRs #12817

Closed
AlexTugarev opened this issue Sep 9, 2022 · 0 comments · Fixed by #13292
Closed

Webhook events are not registered properly for GitHub PRs #12817

AlexTugarev opened this issue Sep 9, 2022 · 0 comments · Fixed by #13292
Labels
team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@AlexTugarev
Copy link
Member

On GitHub PR updates we are missing proper pull_request.synchronize handling for webhook event registration.

Also, it we're triggering two prebuilds for the same commit, one for the PR event (context URL is the PR,) and another for the push event (context URL is the branch.)

Follow-up to #11356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
🍎 WebApp Team
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[server][github] record "pull" webhook events gitpod-io/gitpod
1 participant
@AlexTugarev