Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build speed: Install/preview-docker #12824

Closed
mads-hartmann opened this issue Sep 9, 2022 · 2 comments · Fixed by #13093
Closed

Build speed: Install/preview-docker #12824

mads-hartmann opened this issue Sep 9, 2022 · 2 comments · Fixed by #13093
Assignees

Comments

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Sep 9, 2022

The component install/preview gets rebuild on every build because it has an argdeps dependency on version. This dependency is needed, which means that for now, we can't avoid having the component be rebuild with every build.

However, we can make it optional to build the component. install/preview:docker isn't needed on all branches, so we could hide it behind a "with-preview-docker" Werft attribute.

Being able to dynamically decide if a component should be build or not depends on a new feature in Leeway (gitpod-io/leeway#95)

@mads-hartmann
Copy link
Contributor Author

Quick note from chat with Chris

See docs at https://github.com/gitpod-io/leeway#dynaimc-package-scripts. There is no release yet, create a release by creating a tag v.0.2.21 then a GH action will run and produce the release

@mads-hartmann
Copy link
Contributor Author

✅ Leeway release created here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant