Make local-preview optional #13093
Merged
Make local-preview optional #13093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mads-hartmann
force-pushed
the
mads/make-preview-docker-optional
branch
from
dc1d3dd to
529cb19
Compare
mads-hartmann
force-pushed
the
mads/make-preview-docker-optional
branch
from
529cb19 to
0625594
Compare
mads-hartmann
force-pushed
the
mads/make-preview-docker-optional
branch
from
0625594 to
0779e13
Compare
mads-hartmann
force-pushed
the
mads/make-preview-docker-optional
branch
from
0779e13 to
fea4261
Compare
github-actions
bot
added
the
team: delivery
Pothulapati
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
LGTM, and the jobs seemed to have the expected output! Great Work @mads-hartmann!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the the local-preview component (
./install/preview, packageinstall/preview:docker) to be a dynamic package that will only be built if-DwithLocalPreview=trueis passed to Leeway.Werft will build the package by default on main, otherwise I will only build it if the Werft attribute
with-local-previewis set. This PR adds that attribute to the default PR template to make it easier to discover and set.The motivation for this change is to speed up builds. See #12824 for more context
Related Issue(s)
Fixes #12824
How to test
werft job run github- see job and screenshot belowwerft job run github -a with-local-preview=true- see job and screenshot belowRelease Notes
Documentation
N/A
Werft options:
Valid options are
all,workspace,webapp,ide