Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Enable the ability to build install/preview:docker in Werft again #13313

Closed
mads-hartmann opened this issue Sep 26, 2022 · 0 comments
Closed
Assignees

Comments

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Sep 26, 2022

In #13093 install/preview:docker was turned into a dynamic package to make it optional to build. However, it appears that dynamic packages currently break leeway exec (see gitpod-io/leeway#100) and due to a misunderstanding install/preview:docker was removed from the "all" package dependency tree in #13240. That means that currently, you can't build install/preview:docker in CI.

The easiest fix is that doesn't break leeway exec is the

  1. Convert it back to a "normal" package
  2. But keep it out of the ":all" package dependency tree
  3. Instead use leeway build install/preview:docker in Werft when the --with-local-preview is enabled.

⬆ This also means that it's easier to build the package in Gitpod as you don't have to pass in the build argument that the dynamic package relied on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant