Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a normal component and conditionally build it using leeway build #13368

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

mads-hartmann
Copy link
Contributor

@mads-hartmann mads-hartmann commented Sep 27, 2022

Description

See #13313 for context for why we're moving away from a dynamic package. This PR ensures that we can build install/preview:docker in Werft again. There's a small overhead in running "leeway build" twice, but it does not appear to be bad and it is only relevant when 'with-local-preview' is enabled.

Related Issue(s)

#13313

How to test

See the job

Screenshot 2022-09-27 at 14 47 27

Release Notes

NONE

Documentation

N/A

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@mads-hartmann
Copy link
Contributor Author

mads-hartmann commented Sep 27, 2022

/werft run

👍 started the job as gitpod-build-mads-hartmann-build-enable-the-13313.1
(with .werft/ from main)

@mads-hartmann mads-hartmann marked this pull request as ready for review September 27, 2022 12:50
@mads-hartmann mads-hartmann requested a review from a team September 27, 2022 12:50
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 27, 2022
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@roboquat roboquat merged commit 3c7c79b into main Sep 27, 2022
@roboquat roboquat deleted the mads-hartmann/build-enable-the-13313 branch September 27, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants