Skip to content

Implement scopes update UI #14617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #14280
laushinka opened this issue Nov 11, 2022 · 5 comments · Fixed by #15015
Closed
Tracked by #14280

Implement scopes update UI #14617

laushinka opened this issue Nov 11, 2022 · 5 comments · Fixed by #15015

Comments

@laushinka
Copy link
Contributor

No description provided.

@jeanp413
Copy link
Member

@gtsiolis is there a mockup for this?

@gtsiolis
Copy link
Contributor

@jeanp413 Is this about editing a token? If yes, scopes are already included there for change, but for now we have permissions that's always enabled. Cc @laushinka @easyCZ

@easyCZ
Copy link
Member

easyCZ commented Nov 28, 2022

Indeed, by default, there should be no Permissions selected (checkbox empty). The user should explicitly choose check that box to include all permissions. Similarly,

  • If a user selected no perms, they should be able to edit the token and add all scopes
  • If they selected all scopes, they should be able to unselect and update the token to have no scopes

@easyCZ
Copy link
Member

easyCZ commented Nov 28, 2022

A user can also update the name of the token (which I believe is already implemented)

@gtsiolis
Copy link
Contributor

Thanks for clarifying, @easyCZ! Unless I'm missing something, this means that reusing the existing patterns and simply enabling the permissions checkbox could suffice here. Cc @jeanp413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants