Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Deprecate GitHub Apps #14661

Closed
4 tasks
geropl opened this issue Nov 14, 2022 · 3 comments
Closed
4 tasks

Epic: Deprecate GitHub Apps #14661

geropl opened this issue Nov 14, 2022 · 3 comments
Labels
meta: stale This issue/PR is stale and will be closed soon type: epic

Comments

@geropl
Copy link
Member

geropl commented Nov 14, 2022

Summary

We still support "Gitpod" GitHub Apps that users can install on their GH orgs/repos, and are used to setup webhooks and update prebuild status on PRs. Since Q1/22 we have a different mechanism to register webhooks, which became the default, because it's much more convenient.

Because of the following reasons we are looking onto deprecating it:

  • you have to use 1 App per Gitpod installation: this was already arkward when using one repo from Self-Hosted and gitpod.io, and will get more arkward when we find ways to setup even more Gitpod installations
  • it was hard to explain customers that GitHub has 2 kinds of "Apps": "OAuth App" (required) and "GitHub App" (to be installed on specific repos by members, but configured at config time 🙄 )
  • the only feature we're currently missing is "send prebuild status/comments to Pull Request". Which would be nice, because we eventually also want this to be supported for other SCMs like GitLab and BitBucket (Send commit statuses to GitLab, Bitbucket, and GitHub Enterprise #8796)

To completely replace the OAuth app, though, it would be nice to allow users to configure credentials/a token on the Project-level. But that's an useful feature anyway, and independent of this effort.

Context

See Summary.

Value

  • get rid of two different ways of registering webhooks
  • get rid of Probot app and dependencies
  • finally support "Prebuuild Status Updates" for other SCMs

Acceptance Criteria

Measurement

  • We could remove all code without feature degredation

Growth Area

No response

Persona(s)

No response

Hypothesis

No response

In scope

No response

Out of scope

No response

Complexities

No response

Press release

No response

@svenefftinge
Copy link
Member

The GitHub App allows for doing certain actions as "Gitpod", that is indeed only comments and checks on PRs and issues atm. I agree we should decouple prebuilds and projects from github app installations.

@svenefftinge svenefftinge changed the title Epic: Try to deprecate GitHub Apps Epic: Deprecate GitHub Apps Nov 14, 2022
@stale
Copy link

stale bot commented Feb 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 21, 2023
@stale stale bot closed this as completed Jun 11, 2023
@github-project-automation github-project-automation bot moved this to In Validation in 🍎 WebApp Team Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: stale This issue/PR is stale and will be closed soon type: epic
Projects
Status: In Validation
Development

No branches or pull requests

2 participants